This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: set lockfileVersion from file during reset #340
Closed
+107
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
commented
Oct 21, 2021
| const loadAndReset = (options) => Promise.all([ | ||
| Shrinkwrap.load(options).then((s) => s.lockfileVersion), | ||
| Shrinkwrap.reset(options).then((s) => s.lockfileVersion), | ||
| ]) |
There was a problem hiding this comment.
I thought it was worthwhile to reuse the existing tests for Shrinkwrap.load to ensure that all calls to Shrinkwrap.reset work as expected.
Currently there are some calls to Shrinkwrap.reset that leave lockfileVersion as null when the existing shrinkwrap lockfileVersion is less than or equal to the default version. I'm not sure if it's worth changing so that reset always sets lockfileVersion to 1 || 2 || 3 when reading from disk.
lukekarrys
force-pushed
the
lk/update-downgrade-lockfile
branch
2 times, most recently
from
95d850a
to
5aaf60c
Compare
Fix: npm/cli#3920 When loading the initial tree while updating all, a shrinkwrap file loaded from disk with an existing `lockfileVersion` was not having the `lockfileVersion` preserved when saving the file back to disk. With this patch, an existing `lockfileVersion` is preserved if it is greater than the `defaultLockfileVersion`. Co-authored-by: @isaacs
lukekarrys
force-pushed
the
lk/update-downgrade-lockfile
branch
from
5aaf60c
to
bb14047
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: npm/cli#3920
When loading the initial tree while updating all, a shrinkwrap file
loaded from disk with an existing
lockfileVersionwas not having thelockfileVersionpreserved when saving the file back to disk.With this patch, an existing
lockfileVersionis preserved if it isgreater than the
defaultLockfileVersion.